-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ibexa/rector] Backported Ibexa Rector recipe to 4.6 #152
base: master
Are you sure you want to change the base?
Conversation
Thanks for contribution! 🎉 To test the changes please execute:
before executing the recipes. |
|
Yes, please introduce dedicated set for 4.6. After the 5.0 release set will start differ from 4.6. |
11e75ee
to
7c51b1b
Compare
|
Changed accordingly, requesting 2nd round of review as the solution changed. |
Related PRs:
Description:
This PR backports
5.0
configuration to4.6
.4.6
branch is already available foribexa/rector
package.Ibexa 5.0 set contains deprecations that should be removed in 4.6 anyway.
There might be some minor differences (like we deprecated something in 5.0 only). We could approach that in several ways:
Keep different contents of5.0
set list between4.6
and5.0
branches inibexa/rector
package,5.0
set as the4.6
set with changes, ✔️ chosen solutionEnsure all5.0
rules are executable on4.6
.Update Jan 28: after today's dry run for the presentation the conclusion was that having
IBEXA_46
set would look less confusing in case of 4.6.Update Mar 12: changed PR to use
IbexaSetList::IBEXA_46
set for 4.6.