Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8117: [ibexa/rector] Added default configuration for ibexa/rector #119

Merged
merged 3 commits into from
May 17, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented May 9, 2024

🎫 Issue IBX-8117

Related PRs:

Description:

This is default ibexa/rector config file (./rector.php) to be installed when installing ibexa/rector package.

For QA:

Optionally, confirm that this recipe gets installed when requiring ibexa/rector.

Documentation:

Possibly needs to be mentioned when documenting rector that this is expected to happen (if we decide to document this outside of the package README).

Copy link

github-actions bot commented May 9, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-119

before executing the recipes.

@alongosz alongosz force-pushed the ibx-8117-rector-config-recipe branch from 01df96f to 36b71c4 Compare May 9, 2024 17:18
@alongosz alongosz requested review from webhdx and a team May 9, 2024 17:21
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alongosz alongosz requested a review from a team May 10, 2024 10:03
@konradoboza konradoboza requested a review from a team May 10, 2024 10:10
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit e13df69 into master May 17, 2024
2 checks passed
@alongosz alongosz deleted the ibx-8117-rector-config-recipe branch May 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants