Removed deprecation RestKernelViewSubscriber #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Mar 10, 2025
ciastektk
approved these changes
Mar 10, 2025
tbialcz
approved these changes
Mar 10, 2025
wiewiurdp
force-pushed
the
remove-deprecated-restkernelviewsubscriber
branch
from
ff1b573 to
0e4eb8f
Compare
|
alongosz
reviewed
Mar 10, 2025
Comment on lines
-27
to
-29
| * @deprecated This is a temprary approach to caching certain parts of REST used by UI, it is deprecated in favour of | ||
| * nativly using tags and CachedValue in kernel's REST server itself once we switch to FOSHttpCache 2.x | ||
| * where tagger service can be used directly. |
There was a problem hiding this comment.
Internal sync: seems there's more work to be done to utilize FOSHttpCache than just removing the subscriber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed deprecation RestKernelViewSubscriber