Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config activity log as a post-installation step #2663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 7, 2025

Question Answer
JIRA Ticket N/A
Versions 4.6, master
Edition All

At the end of installation process, suggest to configure activity log to limit its length.
I add "Configure recent activity log" section before the two other cron related sections because it can be critical to fill up DB with activity log while the other two are just feature enablements.

Preview

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

github-actions bot commented Mar 7, 2025

Preview of modified Markdown:

@adriendupuis adriendupuis marked this pull request as ready for review March 7, 2025 12:30
@adriendupuis adriendupuis requested a review from Sztig March 7, 2025 12:30
### Configure recent activity log

Actions in a repository are logged in its database,
you may want to [limit this log length by enabling its automatic truncation](recent_activity.md#configuration-and-cronjob).
Copy link
Contributor

@dabrt dabrt Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"you may want" gives readers an option, but you do not explain why they might want to limit the length of the log. Is there defult value that is too big? Does it cause memory issues?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to change the wording a bit. By default we are not truncating the log at all. The biggest problem is when the log is long overdue (milliions of records set to be deleted) on truncate the command will eat up resources rendering the site unavailable for a while. Imo if the command is implemented as it is right now, we should strongly recommend to have this cronjob set up by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the advice is... performance related, I would move it to the following article: Performance
where we have more such pieces of advice.

And there, I would provide a longer explanation:
"Actions in a repository are logged in its database.
When there's a large number of records and they need to be processed, it may impact the productivity of your application.
To avoid this, you may want to limit the log's length by enabling its automatic truncation after a total number of entries reaches a certain threshold."

I would also include a direct link to the "Performance" article in the installation procedure, I feel like it is missing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants