Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan: Upgrade to 2.0 #2654

Merged
merged 2 commits into from
Mar 12, 2025
Merged

PHPStan: Upgrade to 2.0 #2654

merged 2 commits into from
Mar 12, 2025

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Mar 5, 2025

Target: 4.6 only ‼️

Follow-up to #2644

Looks like PHPStan 2.0 started detecting one potential issue:

		-
			message: '#^Return type \(bool\) of method App\\Security\\Limitation\\Mapper\\CustomLimitationValueMapper\:\:mapLimitationValue\(\) should be compatible with return type \(array\<mixed\>\) of method Ibexa\\AdminUi\\Limitation\\LimitationValueMapperInterface\:\:mapLimitationValue\(\)$#'
			identifier: method.childReturnType

This could be a potential broken code sample - will require seperate investigation.

@mnocon mnocon marked this pull request as ready for review March 5, 2025 14:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Preview of modified Markdown: no Markdown change to preview.

@mnocon mnocon merged commit c01c91e into 4.6 Mar 12, 2025
7 checks passed
@mnocon mnocon deleted the phpstan-46 branch March 12, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrt dabrt dabrt approved these changes

@adriendupuis adriendupuis Awaiting requested review from adriendupuis

@julitafalcondusza julitafalcondusza Awaiting requested review from julitafalcondusza

Assignees
No one assigned
Labels
Needs DOC review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnocon @dabrt