Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct error type in WmctrlExecutor::executable? #14

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

pluiedev
Copy link
Contributor

Not sure if this needs a test case β€” either way I don't really know how to write one πŸ˜…

Fixes #13

@iberianpig
Copy link
Owner

iberianpig commented Jan 26, 2024

Thank you. The constant missing error will be fixable with this PR.

However, we got my new task that needs to be fixed.

  • It seems that it was not compatible with Fusuma 3, tests was failing
  • I found a commit from a previous refactoring of the exception class.
    • f82644420cd78826a48dbe18678de
    • This refactoring is still not sufficient and the exception class must be wrapped on the Executor side and resubmitted as InvalidOptions.

I merge this PR, but the release will likely follow in order to proceed with the above tasks.

@iberianpig iberianpig merged commit a4e2fa2 into iberianpig:main Jan 26, 2024
1 check failed
@iberianpig iberianpig added the bug Something isn't working label Jan 26, 2024
@iberianpig iberianpig self-requested a review January 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError in WmctrlExecutor::executable?
2 participants