Add licenseFileNamePartsToFind option #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's actually gulp-coverage that fails silently because of reasons explained here sindresorhus/gulp-mocha#159 and then gulp-coveralls has nothing to send. |
|
I've made a significant change to nlf to support npm3 which is probably going to conflict with this. Now that it doesn't support node < 4 I'm planning to significantly rewrite this to be cleaner and more es6y. |
|
Ok, let me know when your es6 branch is in good enough shape so that I can redo the idea of this pull request to it also. Or perhaps then when it merges the main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalized the support for arbitrary license file names because of the need for file name "copying". This merge could solve also issue #43.
About implementation: To avoid callback hell when looping through given file names refactored the code ( b6f6c06) to use generator functions in createModule function. Next, added licenseFileNamePartsToFind option that must be array of file names (or regexps). To support newish "license" file variations #44 array items can also contain alternative license collection name. So, the default for this parameter is
[['li@(c|s)en@(c|s)e', 'license'], 'readme'].Unfortunately, to support generator functions in tests, had to upgrade gulp-mocha and therefore the gulp-coveralls now fails. The Coveralls integration plugin seems to be quite old and there's no more new version available.