Fixed Incorrect parsing of timestamp passing as string#2968
Open
Khyati-Kapil wants to merge 1 commit intoiamkun:devfrom
Open
Fixed Incorrect parsing of timestamp passing as string#2968Khyati-Kapil wants to merge 1 commit intoiamkun:devfrom
Khyati-Kapil wants to merge 1 commit intoiamkun:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(parse): correctly parse numeric string timestamps as timestamps
Previously, dayjs("1762232987879") would attempt to parse the string as a date format, resulting in an incorrect negative timestam and wrong date formatting. This occurred because the regex for date parsing matched the string before checking if it was a numeric timestamp.
Now, numeric string timestamps are checked and parsed as timestamps before attempting date string parsing.
This fix resolves issues with isBefore, isAfter, and formatting methods when using numeric string inputs.