fix: timezone parsing bug - Partially addresses #1827 #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelPlutaUek20
commented
Aug 21, 2025
| // timestamp number || js Date || Day.js | ||
| return d(input).tz(timezone) | ||
| } | ||
| const previousOffset = tzOffset(+d(), timezone) |
There was a problem hiding this comment.
@iamkun I moved this function below the return statement. There's not reason to compute this earlier.
PawelPlutaUek20
commented
Aug 21, 2025
| expect(dayjs2.format()).toBe('2012-02-01T13:50:21-03:00') | ||
| const dayjs3 = dayjs.tz('2022-02-03T13:50:21-00:00', 'America/Recife') | ||
| expect(dayjs3.format()).toBe('2022-02-03T10:50:21-03:00') | ||
| // TODO: support rfc2822 dates |
There was a problem hiding this comment.
I might address this in a future pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1827
This solution does not work with rfc2822 dates, but fixes the issues with iso dates. It's a good step forward.