Skip to content

(FIX) Fixed first endpoint not being extended over zero gradient junctions #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(FIX) Fixed first endpoint not being extended over zero gradient junctions #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/EdgeDrawer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ void EdgeDrawer::drawEdgeTreeStack(Pixel anchor, ImageEdge &initialPixels, bool
uint8_t direction, gradDir, lineDirection;
int i, indexInArray, lastChekedPxIdx, initialPxIndex, indexInImage, nElements;
bool addPixelsForTheFirstSide, inlierOverwritten, popStack, firstBranch, isAnchorFirstPx, wasExtended;
bool localSegInitialized, segment;
bool localSegInitialized, segment, pxFound;
Pixel px, lastPx;
double fitError;
ImageEdge extensionPixels, outliersList;
Expand Down Expand Up @@ -141,6 +141,7 @@ void EdgeDrawer::drawEdgeTreeStack(Pixel anchor, ImageEdge &initialPixels, bool
lastChekedPxIdx = initialPxIndex;
// The current number of inliers
outliersList.clear();
pxFound = false;
inlierOverwritten = false;

lastPx = calcLastPixelWithDirection(px, direction);
Expand All @@ -150,7 +151,9 @@ void EdgeDrawer::drawEdgeTreeStack(Pixel anchor, ImageEdge &initialPixels, bool
localSegInitialized = false;
while (outliersList.size() <= UPM_MAX_OUTLIERS_TH) {

if (!findNextPxWithGradient(gradDir, gradImg, imageWidth, imageHeight, px, lastPx)) {
pxFound = findNextPxWithGradient(gradDir, gradImg, imageWidth, imageHeight, px, lastPx);

if (!pxFound) {
// Stopping because the gradient level is 0 or the pixel is out of the image
break;
}
Expand Down Expand Up @@ -310,7 +313,7 @@ void EdgeDrawer::drawEdgeTreeStack(Pixel anchor, ImageEdge &initialPixels, bool
// BRANCH 1
wasExtended = localSegment->firstEndpointExtended;
// If we can go on straight forward skipping some pixels do it
if ((outliersList.size() > UPM_MAX_OUTLIERS_TH || inlierOverwritten) &&
if ((outliersList.size() > UPM_MAX_OUTLIERS_TH || inlierOverwritten || !pxFound) &&
!wasExtended && treatJunctions && canSegmentBeExtended(*localSegment,
true,
extensionPixels)) {
Expand Down