style: 💄

iadvize · Oct 21, 2015 · 11d9443 · 11d9443
1 parent e0d8c7d
commit 11d9443
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/Command/Scan.php b/src/Command/Scan.php
@@ -2,6 +2,7 @@
 
 namespace Iadvize\SwaggerizeFastRoute\Command;
 
+use Iadvize\SwaggerizeFastRoute\OperationParser\LumenControllerOperationParser;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -54,7 +55,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $routeStream = 'php://output';
         }
 
-        $operationParser = new \Iadvize\SwaggerizeFastRoute\OperationParser\LumenControllerOperationParser($controllerNamespace);
+        $operationParser = new LumenControllerOperationParser($controllerNamespace);
 
         $routes = \Iadvize\SwaggerizeFastRoute\scan($swaggerFile, $operationParser);
 

diff --git a/src/OperationParser/LumenControllerOperationParser.php b/src/OperationParser/LumenControllerOperationParser.php
@@ -56,9 +56,9 @@ public function getHandler(OperationReference $operation)
         $paths = explode('/', $path);
         // path start with a /
         unset($paths[0]);
-        foreach ($paths as &$path) {
-            $path[0] = strtoupper($path[0]);
-        }
+        $paths = array_map(function ($path) {
+            return ucfirst($path);
+        }, $paths);
         // path to 'relative' namespace
         $path = implode('\\', $paths);
 

diff --git a/src/functions.php b/src/functions.php
@@ -80,6 +80,10 @@ function addRoutes($swaggerJson, RouteCollector $routeCollector, OperationParser
  */
 function cacheRoutes(array $routes, $stream)
 {
+    if (is_writable($stream)) {
+        throw new \LogicException($stream . ' is not writable');
+    }
+
     $routeResource = fopen($stream, 'w');
 
     $serializedRoutes = var_export($routes, true);