-
Notifications
You must be signed in to change notification settings - Fork 231
Add ability to filter GCS (CRS) by unit #8629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@simnorm @ashar-bentley @arome , plz review the api meets your expectations / needs |
|
out of curiosity, is there any value in mapping the units returned here with names of ECUnits? |
There could be. I think it is out of scope for this initial task. |
|
This looks great, in our use case we want to filter out one option. Do you think this should be implemented on the API level or should we just fetch everything and filter it out based on the unit you now added |
I think filter based on the unit. |
|
hey @ben-polinsky any update on this PR? |
Add unit to CRS returned by
getAvailableCoordinateReferenceSystemsand allow filtering based on a case-insensitive unit string passed as an argument to the same function.Also expose a function
getAvailableCRSUnitswhich returns an array of all CRS units used. This is helpful because some units contain language variations: "metre" vs "meter", for instance, and it is useful to see what are known values.Closes #8614
imodel-native: iTwin/imodel-native#1244