-
Notifications
You must be signed in to change notification settings - Fork 231
Internal classes for constructing circles tangent to circles and lines. #8261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
EarlinLutz
wants to merge
62
commits into
master
Choose a base branch
from
edl/tangencyConstructions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeeedtorabi
requested changes
Aug 26, 2025
saeeedtorabi
requested changes
Aug 26, 2025
core/geometry/src/curve/internalContexts/geometry2d/ConstraintConstruction.ts
Show resolved
Hide resolved
core/geometry/src/curve/internalContexts/geometry2d/ConstraintConstruction.ts
Show resolved
Hide resolved
saeeedtorabi
requested changes
Aug 26, 2025
core/geometry/src/curve/internalContexts/geometry2d/ConstraintConstruction.ts
Show resolved
Hide resolved
saeeedtorabi
requested changes
Aug 29, 2025
saeeedtorabi
requested changes
Aug 29, 2025
core/geometry/src/curve/internalContexts/geometry2d/TangentConstruction.ts
Show resolved
Hide resolved
…nality can be reached in the future by adding optional fields to ImplicitGeometryMarkup
…itwinjs-core into edl/tangencyConstructions
Member
|
Just a reminder to update NextVersion.md with a nice example of the API: code and image output. You can even scrape this from the tests. This will help users see what the API does, and how to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class ImplicitCurve2d is an abstract class for curves which have a function f(x,y) which is zero for all points on the curve (and nonzero elsewhere). Although most common curves (circles, lines, hyperbola, ellipse) can satisfy this implicit f(x,y)=0 condition AND have a parametric form (x,y,) = g(t) for a parameter t, the parametric form is NOT universal, and the "implicit curve" category warrants distinct implementations for some constructions.
The following concrete implementations are included in this category:
The class ConstrainedConstruction contains static methods for common circle constructions. Each of these is a specific method to encapsulate the construction. They may be called directly if caller has identified the combination. If caller has varied construction constraints, they may be passed as an array to the to dispatch logic noted further below.
The following methods on ConstructionSet have logic to examine 2 or 3 constraints and dispatch to an appropriate method in the lists above:
(In the tangency constructions, the input circles may be zero radius, i.e. act as isolated points.)