handling special bearing format + lower/upper casing + tests on invalid input #7513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hl662
reviewed
Jan 3, 2025
| inString = inString.substring(0, inString.length - DirectionLabel.West.length); | ||
| matchedSuffix = DirectionLabel.West; | ||
| } | ||
|
|
||
| // check if the remaining string is a special direction | ||
| if (inString.trim() === "") { | ||
| const prefix = matchedPrefix?.toLowerCase() || ""; |
There was a problem hiding this comment.
seeing how matchedPrefix/matchedSuffix will always come from an enum returning upper case characters, why not avoid having to convert to lowercase here, and change the keys of specialDirections to be all uppercase instead?
hl662
reviewed
Jan 3, 2025
| if (matchedPrefix === null || matchedSuffix === null) { | ||
| return { ok: false, error: ParseError.BearingPrefixOrSuffixMissing }; | ||
| } | ||
|
|
||
| const parsedResult = this.parseAndProcessTokens(inString, spec.format, spec.unitConversions); | ||
| if(this.isParseError(parsedResult) || !parsedResult.ok) { | ||
| if(this.isParseError(parsedResult)) { |
There was a problem hiding this comment.
maybe also remove the RHS of the || at the start of parseAzimuthFormat() as well, to be consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7489
In addition addressing casing and special strings, I added tests for out-of-bound numbers/possible invalid inputs.
Couple observations:
these work as treating the missing sections as 00
4, allows numbers bigger than 90 to occur (tests added in this pr)
The parseAndProcessTokens implementation is relatively loose, which seems acceptable to me. Let me know if any behavior is unexpected.