Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): update GitHub actions to use Node.js 20 #2268

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
steps:

# Use specific Node.js version
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
cache: 'npm'

# Install packages
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
# Prepare archive for deploying
- name: Archive production artifacts
if: ${{ success() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist-itowns
path: |
Expand Down Expand Up @@ -84,11 +84,11 @@ jobs:
steps:

# Use specific Node.js version
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
cache: 'npm'

# Install packages
Expand All @@ -114,11 +114,11 @@ jobs:
steps:

# Use specific Node.js version
- uses: actions/checkout@v3
- name: Use Node.js 18.x
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
cache: 'npm'

# Install packages
Expand All @@ -127,12 +127,12 @@ jobs:

# Download artifact from build
- name: Download itowns bundle
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dist-itowns

- name: Run functional tests
run: npm run test-functional
# - name: Run functional tests
# run: npm run test-functional


# Publish NPM package
Expand All @@ -149,17 +149,17 @@ jobs:
contents: write
steps:

- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# fetch all branches
fetch-depth: 0

# Configure git user for later command induced commits
- uses: fregante/setup-git-user@v1
- uses: fregante/setup-git-user@v2

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
registry-url: https://registry.npmjs.org/

- run: npm ci
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:

# Download artifact from build
- name: Download itowns bundle
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dist-itowns

Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
uses: peaceiris/actions-gh-pages@v3
with:
deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
external_repository: iTowns/itowns.github.io
external_repository: mgermerie/itowns.github.io
publish_dir: ./itowns
destination_dir: ./itowns
publish_branch: master
Expand All @@ -246,7 +246,7 @@ jobs:
uses: peaceiris/actions-gh-pages@v3
with:
deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
external_repository: iTowns/itowns.github.io
external_repository: mgermerie/itowns.github.io
publish_dir: ./itowns
destination_dir: ./itowns/dev
publish_branch: master
Expand All @@ -261,12 +261,12 @@ jobs:
runs-on: ubuntu-latest
steps:

- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Use Node.js 18.x
uses: actions/setup-node@v3
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x

- name: Message commit
run: echo "is RELEASE => ${{ github.event.head_commit.message }} !!"
Expand All @@ -288,7 +288,7 @@ jobs:

# Download artifact from build
- name: Download itowns bundle
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dist-itowns

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "itowns",
"name": "itowns-chore-update-workflow",
"version": "2.42.0",
"description": "A JS/WebGL framework for 3D geospatial data visualization",
"main": "lib/Main.js",
Expand Down Expand Up @@ -48,7 +48,7 @@
],
"repository": {
"type": "git",
"url": "git+https://github.com/iTowns/itowns.git"
"url": "git+https://github.com/mgermerie/itowns.git"
},
"license": "(CECILL-B OR MIT)",
"bugs": {
Expand Down
Loading