Adrian hodrea #5
Conversation
|
|
||
| function onHtmlLoaded() { | ||
|
|
||
| const id = window.localStorage.getItem("productId"); |
There was a problem hiding this comment.
Good job with the event listener, the lines above being part of the onHtmlLoaded function please add the indentations to them.
|
|
||
| function renderProducts(productsContainer, productsList) { | ||
| productsList.forEach(item => { | ||
| var { id, name, imgUrl } = item; |
There was a problem hiding this comment.
Please use let or const, you can do that inside a forEach loop too.
frontend/models/Product.js
Outdated
|
|
||
| static getProductDetails(id) { | ||
| const productApiUrl = productsApiUrl + `/${id}`; | ||
| return fetch (productApiUrl, |
There was a problem hiding this comment.
Good job creating a separate class for Product, the getProductDetails to return a promise isn't a good practice. You can use async await it's a cleaner way or simply return the response when you're resolving the promise in the function.
For example:
instead of: Product.getProductDetails(id) .then(productData => renderProductDetails(productDetailsContainer,productData));
you can use: renderProductDetails(productDetailsContainer, Product.getProductDetails(id))
If you create a class it's better if you do an export default and than import.
Please pull the code