Mixer: the output map reserves no pad for a Smart ESC motor

[MrScothh]

The Output Mapping preview in the Mixer tab simulates the firmware's assignment of pads to motors and servos while the rules on screen are not saved yet. iNavFlight/inav#12140 makes the firmware reserve no motor pad for a protocol with no timer waveform, where the ESC is driven over a UART, so the simulation now passes no motors in that case and the servos are drawn from the first pad, as the board will assign them. The tab loads the ESC protocol with the rest of its data to know which case it is in; the SRXL2 protocol number and the check live in fc.js, next to the protocol table.

With a saved configuration the tab keeps showing what the board reports, so the preview and the board agree in both states. This should go in together with the firmware change: on a board still running 10.0.0-rc1 or rc2, the preview after an unsaved edit would show Servo 1 on a pad that firmware still gives to the motor, until the next save and reboot puts the board's own table back on screen.

Testing

TBS Lucid H7 Wing (Avian Smart ESC on UART8, airplane mixer with servos 1 to 8) running the firmware change, every timer on AUTO:

• fresh Mixer tab, board-reported table: S1 to S8 are Servo 1 to Servo 8, S9 to S13 empty, no motor;
• after editing a rule's weight without saving, the local preview shows the same table; before this change it drew Motor 1 on S1 and shifted the servos.

yarn test: as on maintenance-10.x on Windows, only the MZTC sender scan fails, for the path separator (#2826). Trial merges with #2814, #2815, #2828 and #2818 are clean.

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Align Mixer output preview with UART-driven Smart ESC assignments

🐞 Bug fix 🕐 10-20 Minutes

AI Description

• Load the ESC protocol when opening Mixer so its output preview has current configuration data.
• Reserve no motor pad for SRXL2, allowing unsaved servo edits to match firmware assignments.
• Keep using board-reported assignments when a direct output map is available.

Diagram

graph TD
    Mixer["Mixer Tab"] --> MSP["MSP Helper"] --> FC["FC Config"] --> Check{"Uses timers?"} --> Mapping["Output Mapping"] --> Preview["Pad Preview"]
    MSP -->|board assignments| Preview

Loading

High-Level Assessment

The focused protocol check is appropriate: it matches the firmware distinction without changing the shared output-mapping algorithm or replacing board-reported assignments. Passing zero motors reuses the existing servo assignment behavior.

Files changed (2) +9 / -1

Bug fix (2) +9 / -1

fc.jsIdentify SRXL2 as a motor protocol without timer outputs +5/-0

Identify SRXL2 as a motor protocol without timer outputs

• Adds the SRXL2 protocol number and a helper that checks whether the configured motor protocol uses timer outputs. This gives the Mixer preview a shared place to determine whether a motor needs a pad.

js/fc.js

mixer.jsAvoid reserving a motor pad in the SRXL2 preview +4/-1

Avoid reserving a motor pad in the SRXL2 preview

• Loads advanced configuration during Mixer initialization so the ESC protocol is known before rendering. Passes zero motors to the simulated output map for SRXL2, while retaining the existing board-reported direct-assignment path.

tabs/mixer.js

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[github-actions]

Configurator test build ready — commit 6119856

Download build artifacts for PR #2831

Available platforms (scroll to the Artifacts section at the bottom of the run page):

• Windows x64 (ZIP, MSI) and x32 (ZIP, MSI)
• macOS arm64 (ZIP, DMG) and x64 (ZIP, DMG)
• Linux x64 (DEB, RPM, ZIP) and aarch64 (DEB, RPM, ZIP)

A GitHub login is required to download artifacts. Build is for testing only.