Feat: Add ignored statuses #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the requiredStatuses field optional and adds a new field ignoredStatuses. This allows for more flexibility in the configuration of the ignored/required statuses for a repository.
Previously, if requiredStatuses was not set, all statuses were required. Now, if ignoredStatuses is set, statuses in that list are not required.
|
QA 🎬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously could only set
requiredStatuses. This is great if all ci checks runon every PR. We want to conditionally run different workflows on different PRs, so
we can't make certain statuses requried.
Instead, let's create a new
ignoredStatusesthat the user can set so that pulldasherignores those even if they are failing.
QA:
We should verify that ignored statuses don't affect the ci blocked PRs. You can modify
/mnt/ebs/etc/pulldasher-dev.config.jsand update pulldasher dev to make sure thecorrect pulls are in (or out) of the CI Blocked column on pulldasher-dev.cominor.com.
Connects: https://github.com/iFixit/ifixit/issues/52034
cc @danielbeardsley