Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default draft pulls toggle to off #399

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Default draft pulls toggle to off #399

merged 2 commits into from
Dec 5, 2023

Conversation

kthaler
Copy link
Contributor

@kthaler kthaler commented Dec 2, 2023 •
edited
Loading

Drafts are now toggled off by default. Logged in users should see their personal drafts whether or not it is toggled in the nav bar.

QA

Make sure drafts are toggled off by default and check if your personal drafts are still visible

Closes #397

@kthaler
Set showDrafts default to false
d0b785f 
- Drafts are no longer shown by defaul
@kthaler
Show your drafts even if drafts is toggle off
5cac890 
- Change isNotDraft to include drafts that are yours
- Your drafts are now always visible whether or not drafts is toggled
- Drafts will remain in dev_block section
@kthaler kthaler marked this pull request as ready for review December 5, 2023 00:10
@kthaler kthaler mentioned this pull request Dec 5, 2023
Closed
@kthaler kthaler changed the title Default draft pulls toggle to off #398 Default draft pulls toggle to off Dec 5, 2023
danielbeardsley
danielbeardsley approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@danielbeardsley danielbeardsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@jordycosta jordycosta self-assigned this Dec 5, 2023
@jordycosta jordycosta added the QAing Under QA team review label Dec 5, 2023
@jordycosta
Copy link
Member

jordycosta commented Dec 5, 2023 •
edited
Loading

QA 🟢

Draft pull requests are now defaulted to not be displayed immediately (unless it's your own draft)

firefox_lqLP8Iw6X4

@jordycosta jordycosta removed the QAing Under QA team review label Dec 5, 2023
@andyg0808
Copy link
Contributor

deploy_block 👍
Not opposed entirely, but can someone (maybe @erinemay) explain why we want this? Wouldn't hiding everything except your own pulls in Dev Blocked make sense at this point?

@erinemay
Copy link

erinemay commented Dec 5, 2023

@andyg0808 I realized I didn't add any rationale. Sorry! I edited the issue with a bunch more context. #397. Please comment away.

Wouldn't hiding everything except your own pulls in Dev Blocked make sense at this point?

If that's a view that would be helpful to you, let's add an issue. I had kind of hoped this would be a plus for dev managers and neutral for devs.

@andyg0808
Copy link
Contributor

un_deploy_block 👍
I've thought of draft as though it were GitHub-native dev_block. But after seeing @erinemay's comments, I realized that draft is "not ready yet" and "Request changes" in a review is Github-native dev_block. I'm very on-board with this now.

@deltuh-vee deltuh-vee merged commit 692e0f3 into master Dec 5, 2023
1 check passed
@deltuh-vee deltuh-vee deleted the default-draft-pulls branch December 5, 2023 21:41
@erinemay
Copy link

erinemay commented Dec 5, 2023

Do we have to manually redeploy Pulldasher to see changes?

@danielbeardsley
Copy link
Member

Do we have to manually redeploy Pulldasher to see changes?

Yes, there's a script: update-pulldasher

@deltuh-vee
Copy link
Contributor

Just redeployed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbeardsley danielbeardsley danielbeardsley approved these changes

Assignees

@jordycosta jordycosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default draft pulls toggle to off
6 participants
@kthaler @jordycosta @andyg0808 @erinemay @danielbeardsley @deltuh-vee