Add Personal View #391
Merged
Add Personal View #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the UI component that displays the current connection status along with the # of open pulls over to the right-hand side of the navigation bar (before the Search bar). I introduced a <Text> component from Chakra and leveraged a HStack to align this section. I also separated the text of the "open:" and the number of open pulls to make sure that there isn't a horizontal shift in the user interface when the number of open pulls changes.
This function will return a boolean that indicates wether or not a pull request is affiliated/associated with the Pulldasher user. The current conditions to be considered associated: - The pull request is authored by the user - There is either a current or outdated CR signed by the user - There is either a current or outdated QA signed by the user - There is a dev_block signed by the user - There is a deploy_block signed by the user
This setup is necessary for our new Personal View button to be able to toggle the pull filtering on and off. The default state is false, i.e. the personal view is not shown by default,.
This provides a check if a pull request is affiliated with the Pulldasher user. This will be used with setPullFilter() in order to filter out pull requests.
When the personal view is toggled on, this will filter the list of pull requests to just those that are affiliated with the Pulldasher user. All other pull requests will be hidden until the personal view is toggled back off.
This will enable personal view filtering of pull request data.
This adds in hasMyDevBlock() and hasMyDeployBlock() to simplify reading the isMineAffiliated() function. These functions will check if the Pulldasher user has wrote a dev_block and/or deploy_block on a given pull request.
QA 🦕 - This works great! Opens up the opportunity for so much new functionality. |
|
Fantastic @jordycosta !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Demo.mp4
This adds a button that will allow for filtering pulls that you have authored, wrote a signature on, or deploy/dev blocked
QA: Testing Documentation
Closes #383