Recently Closed Pulls: Fix cut-off #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prop was causing the background/box container of the Recently Closed Pulls cards to be cut off early from the bottom of the list. This removes the property causing the issue and resolves the UI cut-off.
This reverts commit af299a8.
This uses 'fit-content' to ensure that the height of the Box that contains the Recently Closed Pulls expands all the way to the bottom of the content. https://developer.mozilla.org/en-US/docs/Web/CSS/fit-content
|
I ran |
|
I think this change is small enough that we can just merge it and revert if something goes wrong. I'll do that later today. |
|
Thanks! This had been annoying me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The background of the Recently Closed Pulls section wasn't reaching down to the bottom of the PR list
Toggle View
CR/QA Notes:
CR: Adds a height CSS prop
QA: Overlord Documentation
This can easily be checked by using browser tools and applying the same property on Pulldasher
Closes #388