Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "draft" option #387

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Add "draft" option #387

merged 2 commits into from
Aug 24, 2023

Conversation

andyg0808
Copy link
Contributor

This adds an option to hide draft pulls on Pulldasher

I tested it with the dummy pulls, and it looks like it does what I want.

Andrew Gilbert added 2 commits August 24, 2023 15:55
Add option to hide draft pulls
d7fa69f 
This allows users who don't want to see draft pulls to avoid them.
Add draft pull to dummy pulls file
03dd82a 
I just copy-pasted another pull, changed the number (to avoid
duplication) and added the `draft` property, which seems to be how
prod indicates a draft pull. It shows up as a draft pull in
Pulldasher, so I think it's correct.
@andyg0808
Copy link
Contributor Author

andyg0808 commented Aug 24, 2023 •
edited
Loading

QA 👍

With drafts disabled

image

With drafts enabled

image

@ianrohde
Copy link
Contributor

Does this require a draft label in github to work? I looked into this briefly earlier, but moved on to other things because I thought that was the case.

@andyg0808
Copy link
Contributor Author

@ianrohde Nope! It uses the isNotDraft function to determine whether a pull should be included or not, and that just checks isDraft() on the pull:
https://github.com/iFixit/pulldasher/pull/387/files#diff-4f876b47a482dd69d9bcae2cf9f64a78546c47b753d4228e61931a2dc4fa9e31R205-R207

ianrohde
ianrohde approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@ianrohde ianrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 💯

@andyg0808 andyg0808 merged commit f805b62 into master Aug 24, 2023
1 check passed
@andyg0808 andyg0808 deleted the add-draft-option branch August 24, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianrohde ianrohde ianrohde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyg0808 @ianrohde