php-token-bucket: replace Travis with GH Actions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlahargou
reviewed
Aug 20, 2024
Comment on lines
+4
to
+9
| push: | ||
| branches: | ||
| - '**' | ||
| pull_request: | ||
| branches: | ||
| - '**' |
There was a problem hiding this comment.
We want to run this on all pushes?
Suggested change
| push: | |
| branches: | |
| - '**' | |
| pull_request: | |
| branches: | |
| - '**' | |
| push: | |
| pull_request: |
There was a problem hiding this comment.
It's fast, so I don't see why not
There was a problem hiding this comment.
It was helpful when debugging which is why I did it. But if it makes more sense to make it PR only, that's fine
mlahargou
reviewed
Aug 20, 2024
mlahargou
reviewed
Aug 20, 2024
.github/workflows/psalm.yml
Outdated
Comment on lines
21
to
30
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.3' | ||
|
|
||
| - name: Run composer install | ||
| run: composer install | ||
|
|
||
| - name: Run psalm | ||
| run: ./vendor/bin/psalm --output-format=github --update-baseline |
There was a problem hiding this comment.
Think all this could be replaced with https://github.com/psalm/psalm-github-actions
mlahargou
reviewed
Aug 20, 2024
Comment on lines
+4
to
+9
| push: | ||
| branches: | ||
| - '**' | ||
| pull_request: | ||
| branches: | ||
| - '**' |
mlahargou
reviewed
Aug 20, 2024
Comment on lines
+19
to
+28
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.3' | ||
|
|
||
| - name: Install dependencies | ||
| run: composer install | ||
|
|
||
| - name: Run tests | ||
| run: vendor/bin/phpunit tests |
There was a problem hiding this comment.
Could be replaced with https://github.com/php-actions/phpunit I think.
mlahargou
previously approved these changes
Aug 20, 2024
Co-authored-by: Michael Lahargou <[email protected]>
|
CR 📱 |
|
Those are all good suggestions, but I'm just gonna merge this cause we're probably not going to change it again for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qa_req 0