Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-gather: Update deps #16

Merged
merged 4 commits into from
Nov 9, 2023
Merged

css-gather: Update deps #16

merged 4 commits into from
Nov 9, 2023

Conversation

mlahargou
Copy link
Member

This just updates a few of the deps for this repo. Nothing crazy I don't think.

QA:

Run through the steps of the README on this repo. Make sure it still works.

Connects: https://github.com/iFixit/ifixit/issues/50016

@mlahargou mlahargou added the QAE Quality Assurance Engineering label Nov 9, 2023
@mlahargou mlahargou self-assigned this Nov 9, 2023
@deltuh-vee deltuh-vee self-assigned this Nov 9, 2023
@deltuh-vee
Copy link
Contributor

dev_block ✊
I ran into this error when running docker-compose build
CleanShot 2023-11-09 at 12 27 04

@mlahargou
Copy link
Member Author

I ran into this error when running docker-compose build

Are you running this on your local machine or cominor?

@deltuh-vee
Copy link
Contributor

@mlahargou I'm running this on my local machine.

@mlahargou
Copy link
Member Author

mlahargou commented Nov 9, 2023

Works fine for me:
image

Does master work for you? Think it might be a problem with your set up.

@deltuh-vee
Copy link
Contributor

deltuh-vee commented Nov 9, 2023

un_dev_block 👍
@mlahargou Hmm it worked on main for me. It's also working for me now. Might have been a networking blip.

@deltuh-vee deltuh-vee added the QAing Under QA team review label Nov 9, 2023
@deltuh-vee
Copy link
Contributor

QA 🎬
Still able to run css-gather.

@deltuh-vee deltuh-vee removed the QAing Under QA team review label Nov 9, 2023
Copy link
Contributor

@batbattur batbattur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🚛

@deltuh-vee deltuh-vee merged commit 52dd654 into main Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QAE Quality Assurance Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants