-
Notifications
You must be signed in to change notification settings - Fork 1
Fix dual-action button and dropdown component bugs #77
Conversation
additionally add `vertical-align: middle` :root `inline-flex` components
To bypass the compiled boilerplate, searching for |
LGTM! CR 🍻 |
dev_block 🌃 found a bug on storybook |
un_dev_block 🧻 |
CR 🍻 |
@@ -169,7 +169,7 @@ | |||
|
|||
&::after { | |||
content: ""; | |||
box-shadow: @shadow-3; | |||
box-shadow: 2px 2px @space-2 rgba(17, 22, 26, 0.2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious... what is the reasoning for it being okay to break from the pre-defined shadows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated because there's a 45 degree rotation on the pseudo-element on line 175, so the pre-defined shadows don't apply.
CR 💀 but maybe consider adding all of the generated files in a separate commit? Also, concerned about the lack of QA. Did you check these changes for browser compatibility? Might raise confidence if we could see before and after images too? |
CR 🌵 @hackalot805 's didn't take for some reason |
For QA, I have an issue open to do a full-pass of all components before we start using these in production: #17 I was spending too much time circling over browser issues repeatedly. Tony and I decided it would be more efficient to do it in one large pass. |
Summary of Changes
Adds:
vertical-align: middle
added to all :rootinline-flex
components to correct alignment when there are multiple inline-flex elements placed inline.Modifies:
alignment=left/right
weren't responsive to parent width.qa_req 0