Prometheus metrics

[staffoleo]

This pr fix an issue with the local keystore and add health-checks and prometheus metrics

[qligier]

I mind enabling the management endpoints by default. Can it be split in a separate configuration? A specific spring profile may do it.

[lfdesousa]

Have you gave it a try with the current version in Master ?
Then only endpoints visible with current version of the Mag on the Master are:

PS C:\Windows\System32> curl http://localhost:9090/actuator
{"_links":{"self":{"href":"http://localhost:9090/actuator","templated":false},"health":{"href":"http://localhost:9090/actuator/health","templated":false},"health-path":{"href":"http://localhost:9090/actuator/health/{*path}","templated":true}}}

To have more you have to enable and expose, what we did is a proposal, because, none of the endpoints needed for Kubernetes are exposed by default, to the availability and the readiness.

If you noticed in the PR, maybe it should not be put like that, because you have too many endpoints exposed and that might not be desirable.

For Prometheus we draw your attention that an extra reference was needed in the POM, without that the endpoint will not appear, but how should we take this forward?

We can have a quick synch if that makes sense.

[qligier]

Why a new keystore in main?

[lfdesousa]

I modified it also in the last commit, to use the test keystore and not the one in main.

[qligier]

Should it not use a test keystore?

[lfdesousa]

Hi Quentin, first of all thank you for your time last Friday.
I did the requested changes in our Repo, and you have them below:
swisspost@71de057
Basically in the default profile I kept, the health endpoint with the addition of those for Kubernetes.
In the metrics profile, I created only the prometheus and metrics endpoints and exposed them.
To use it we need to explicitly set the needed profile.

[lfdesousa]

Fyi, I just did a push in the branch where the changes were requested, can you please have a look at it ?