Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix selector of usernames #36

Merged
merged 2 commits into from
Feb 20, 2021
Merged

fix selector of usernames #36

merged 2 commits into from
Feb 20, 2021

Conversation

paulirish
Copy link
Contributor

@paulirish paulirish commented Feb 20, 2021

makes the extension work again!

image

fixes #34

probably best to land as separate commits, but w/e.

btw @hzoo the rest of the extension worked just fine. pretty impressed given that it's been a while. nice job writing this. :)

Copy link
Owner

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang good stuff @paulirish ♥! Should of looked into it again, but it's been so long and it seemed like a mess at the time. ok merging as is then!

@hzoo hzoo merged commit 6ee9e4f into hzoo:master Feb 20, 2021
@hzoo
Copy link
Owner

hzoo commented Feb 20, 2021

Now just need to figure out deployment again.. seems like github releases is possible now tho!

@hzoo
Copy link
Owner

hzoo commented Feb 20, 2021

Had trouble doing the automated release so tried doing it manually. Looks like it's been so long since the last release I need to resubmit some info regarding privacy practices and other things, so it's still pending! Maybe can look into removing some of these based on the latest ways of doing these things..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still working for anyone?
2 participants