Logo #17
Merged
Logo #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, 512d000 looks not so related to this PR. |
|
it's a good addition (although unrelated) @Pocket-titan, hope it's ok it was modified? We can continue to iterate on it but we can merge this now |
|
Since it's not a project related config, why not put that ignore in users' global gitignore config? |
|
@hzoo Sure thing, I don't mind :) @PeterDaveHello I agree, adding .DS_Store to .gitignore is completely unrelated to this repo & it's better practice to put it in a global config |
|
good points! |
|
Also looks like you need all 3 sizes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14
Designed logo idea with Git branching and nodes.
Ignore .DS_Store