fixed table sizing with length of notes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteri
reviewed
Dec 9, 2024
aesteri
requested changes
Dec 9, 2024
aesteri
requested changes
Jan 5, 2025
src/App.tsx
Outdated
There was a problem hiding this comment.
You should look at how the main branch deals with utilizing main.tsx! We decided to add in new pages for changelog and documentation so this will be helpful in understanding the frontend structure :)
(so basically we are not using App.tsx anymore and it should be deleted!)
src/components/DataTable.tsx
Outdated
| <Input.Wrapper> | ||
| <Textarea | ||
| variant="unstyled" | ||
| value=" |
There was a problem hiding this comment.
Change this back to file.note
src/components/DataTable.tsx
Outdated
| style={{ whiteSpace: "normal", wordWrap: "break-word" }} | ||
| readOnly | ||
| placeholder="Note" | ||
| rows={4} |
There was a problem hiding this comment.
Can you avoid hard coding the amount of rows? Maybe make it dynamic?
src/components/DataTable.tsx
Outdated
| // now with four rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows" | ||
| style={{ whiteSpace: "normal", wordWrap: "break-word" }} | ||
| readOnly | ||
| placeholder="Note" |
There was a problem hiding this comment.
Maybe change this to No notes available?
something like down below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.