Feature/controller manager #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCMast3r
requested changes
Oct 15, 2024
KrishKittur
reviewed
Oct 17, 2024
…ng # with '#' will be ignored, and an empty message aborts the commit. # # On branch feature/controller-manager # Your branch is up to date with 'origin/feature/controller-manager'. # # Changes to be committed: # modified: ../drivebrain_app/main.cpp # modified: ../drivebrain_core_base/include/public/ControllerManager.tpp # modified: ../drivebrain_core_impl/drivebrain_control/src/SimpleController.cpp # modified: ../test/test_controller_manager.cpp #
RCMast3r
requested changes
Nov 12, 2024
drivebrain_core_impl/drivebrain_common_utils/include/ProtobufUtils.hpp
Outdated
Show resolved
Hide resolved
drivebrain_core_impl/drivebrain_comms/include/DBServiceImpl.hpp
Outdated
Show resolved
Hide resolved
drivebrain_core_impl/drivebrain_comms/include/DBServiceImpl.hpp
Outdated
Show resolved
Hide resolved
drivebrain_core_impl/drivebrain_control/src/SimpleController.cpp
Outdated
Show resolved
Hide resolved
drivebrain_core_impl/drivebrain_control/src/SimpleController.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasnt sure if i should have included my cmake chanegs to build my tests, I did but commented them out, can remove if needed