creation of drivebrain app wrapper #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCMast3r
requested changes
Nov 27, 2024
happyCupcake
force-pushed
the
system-wrapper-class
branch
from
afc6e92 to
2b0d3a8
Compare
RCMast3r
requested changes
Jan 7, 2025
| } | ||
| } | ||
|
|
||
| DriveBrainApp::DriveBrainApp(int argc, char* argv[], const DriveBrainSettings& settings) |
There was a problem hiding this comment.
instead of passing in directly the command line / main arguments, i would suggest handling the argument parsing in external functions from this class. they dont need to be part of a class, but it would help be more explicit for application construction arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.