Fix inefficient copy warning by using self instead of ./. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vation As suggested by the Determinate Nix changelog, replace the relative path reference with the flake's self input to avoid unnecessary copying to the store. This improves evaluation performance and reduces file copies. References: https://determinate.systems/posts/changelog-determinate-nix-362/#track-down-and-fix-inefficient-double-copy-causes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the inefficient copy warning identified by Determinate Nix.
Changes
src = ../.;withsrc = self;innix/default.nixselfas a parameter in the flake's callPackageWhy this fix?
The warning appeared because using
./.causes Nix to copy the entire source tree to the store again, which is inefficient. Using the flake'sselfinput avoids this unnecessary copying and improves evaluation performance.Testing
nix flake checkpassesnix buildworks correctlyReferences: https://determinate.systems/posts/changelog-determinate-nix-362/#track-down-and-fix-inefficient-double-copy-causes