Skip to content

Commit

Permalink
Merge pull request #269 from clhuang/patch-1
Browse files Browse the repository at this point in the history
Output instead of CombinedOutput when parsing helm version output
  • Loading branch information
hypnoglow authored Oct 28, 2023
2 parents ecbbc05 + 5297e7b commit ee8f6fb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/helmutil/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var helm3Detected func() bool

func helmVersionCommand() bool {
cmd := exec.Command("helm", "version", "--short", "--client")
out, err := cmd.CombinedOutput()
out, err := cmd.Output()
if err != nil {
// Should not happen in normal cases (when helm is properly installed).
// Anyway, for now fallback to v2 for backward compatibility for helm-s3 users that are still on v2.
Expand Down

0 comments on commit ee8f6fb

Please sign in to comment.