Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for passing additional filters to EntityRequest #199

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

avinashkolluru
Copy link
Contributor

Description

Added support for passing additional filters to EntityRequest

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@avinashkolluru avinashkolluru requested a review from a team as a code owner October 5, 2023 05:30
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Test Results

25 tests  ±0   25 ✔️ ±0   17s ⏱️ -5s
11 suites ±0     0 💤 ±0 
11 files   ±0     0 ±0 

Results for commit e802523. ± Comparison against base commit a98a91c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #199 (e802523) into main (3b8b494) will decrease coverage by 0.15%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #199      +/-   ##
============================================
- Coverage     21.99%   21.84%   -0.15%     
  Complexity       75       75              
============================================
  Files            69       70       +1     
  Lines          1819     1831      +12     
  Branches         55       55              
============================================
  Hits            400      400              
- Misses         1410     1422      +12     
  Partials          9        9              
Flag Coverage Δ
unit 21.84% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pertrace/graphql/entity/request/EntityRequest.java 0.00% <0.00%> (ø)
...ql/entity/request/DefaultEntityRequestBuilder.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that'll allow reverting about half the files here, other than that lgtm

@aaron-steinfeld aaron-steinfeld merged commit 9c1dc82 into main Oct 5, 2023
6 of 8 checks passed
@aaron-steinfeld aaron-steinfeld deleted the entity_request_contextual branch October 5, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants