Resolve PR reviews

hypertrace · Jun 19, 2024 · 05beb61 · 05beb61
1 parent a51d5d7
commit 05beb61
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/...ain/java/org/hypertrace/graphql/spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java b/...ain/java/org/hypertrace/graphql/spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java
@@ -24,7 +24,7 @@ public interface ExcludeSpanRuleUpdate extends Identifiable {
 
   @GraphQLField
   @GraphQLName(SPAN_PROCESSING_FILTER_KEY)
-  @GraphQLDescription("Update the existing spanFilters for the input ruleId")
+  @GraphQLDescription("Replace the existing spanFilters for the input ruleId")
   @GraphQLNonNull
   SpanProcessingRuleFilter spanFilter();
 

diff --git a/...a/org/hypertrace/graphql/spanprocessing/schema/mutation/SpanProcessingMutationSchema.java b/...a/org/hypertrace/graphql/spanprocessing/schema/mutation/SpanProcessingMutationSchema.java
@@ -17,8 +17,7 @@ public interface SpanProcessingMutationSchema {
 
   @GraphQLField
   @GraphQLName(CREATE_EXCLUDE_SPAN_RULE_MUTATION_NAME)
-  @GraphQLDescription(
-      "Create exclude span rule by providing the rule name, filters, rule type, enabled or disabled state")
+  @GraphQLDescription("Creates a new ExcludeSpanRule. See ExcludeSpanRule for more information.")
   @GraphQLNonNull
   @GraphQLDataFetcher(ExcludeSpanCreateRuleMutator.class)
   ExcludeSpanRule createExcludeSpanRule(

diff --git a/...hema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRule.java b/...hema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRule.java
@@ -9,7 +9,7 @@
 
 @GraphQLName(ExcludeSpanRule.TYPE_NAME)
 @GraphQLDescription(
-    "Exclude span rules are the set of rules created using filters on span attributes based on which we exclude spans at source from reaching the platform")
+    "An ExcludeSpanRule describes a set of conditions based on span attributes. When matched, a span is discarded and not eligible for further processing.")
 public interface ExcludeSpanRule extends Identifiable, ExcludeSpanRuleInfo {
   String TYPE_NAME = "ExcludeSpanRule";
 

diff --git a/.../src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleInfo.java b/.../src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleInfo.java
@@ -30,7 +30,7 @@ public interface ExcludeSpanRuleInfo {
   @GraphQLField
   @GraphQLName(DISABLED_KEY)
   @GraphQLDescription(
-      "Disabled field denotes whether the rule is disabled or not. By default it is enabled")
+      "Disabled field denotes whether the rule is disabled or not. By default it is enabled on write")
   @GraphQLNonNull
   boolean disabled();
 

diff --git a/.../hypertrace/graphql/spanprocessing/schema/rule/filter/SpanProcessingRelationalFilter.java b/.../hypertrace/graphql/spanprocessing/schema/rule/filter/SpanProcessingRelationalFilter.java
@@ -18,7 +18,7 @@ public interface SpanProcessingRelationalFilter {
   @GraphQLField
   @GraphQLName(SPAN_PROCESSING_FILTER_KEY_KEY)
   @GraphQLDescription(
-      "Span processing filter key is the span attribute provided as string like http.request.body.email")
+      "Span processing filter key is the span attribute provided as string like http.request.header.authorization")
   String key();
 
   @GraphQLField