Skip to content

Remove transaction isolation level config in PG #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suddendust wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Remove transaction isolation level config in PG #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...tore/src/main/java/org/hypertrace/core/documentstore/postgres/PostgresConnectionPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package org.hypertrace.core.documentstore.postgres;

import static java.sql.Connection.TRANSACTION_READ_COMMITTED;

import java.sql.Connection;
import java.sql.SQLException;
import java.time.Duration;
Expand Down Expand Up @@ -101,7 +99,10 @@ private void setFactoryProperties(
poolableConnectionFactory.setValidationQueryTimeout((int) VALIDATION_QUERY_TIMEOUT.toSeconds());
poolableConnectionFactory.setDefaultReadOnly(false);
poolableConnectionFactory.setDefaultAutoCommit(true);
poolableConnectionFactory.setDefaultTransactionIsolation(TRANSACTION_READ_COMMITTED);
// Note: We intentionally do NOT call setDefaultTransactionIsolation() here.
// PostgreSQL defaults to READ_COMMITTED, which is what we want. Setting it explicitly
// causes DBCP2 to execute "SHOW TRANSACTION ISOLATION LEVEL" on every connection borrow
// (via PgConnection.getTransactionIsolation()), adding unnecessary overhead.
poolableConnectionFactory.setPoolStatements(false);
}

Expand Down
Loading