[Draft] Add MongoPostgresWriteConsistencyTest by suddendust · Pull Request #280 · hypertrace/document-store

suddendust · 2026-03-08T19:43:40Z

This PR adds exhaustive MongoPostgresWriteConsistencyTest to ensure functional parity b/w Mongo and Postgres write implementations. In addition to this, it also:

Fixes a bug in PostgresResultIteratorWithBasicTypes in which float4/real values were cast to strings. So say we have a field ratings with is a real field - It would appear as "4.3" in Document instead of 4.3 (Mongo behaves correctly so this fix is added for functional compatibility).
Added checks on the type of input in update parsers for fail-fast. This is inline with Mongo's behaviour.
Handle array fields properly in SET update parsers to parse them as a single value.
Fix the return behaviour of Collection#upsert for PG. Till now, it returns true if a new doc is created, false if it's updated. This is not inline with the contract or Mongo's behaviour - So now, it returns true if it succeeds.
Handle SET on entire JSONB columns properly.
Unset based on type.

…rite_subDocOperatorRemainingParsers

This reverts commit a1b2208.

This reverts commit 9ffdc44.

suddendust · 2026-03-08T19:44:36Z

document-store/src/main/java/org/hypertrace/core/documentstore/postgres/PostgresCollection.java

          }
          break;

+        case "float4":


Currently for PG, this returns the value as a string. This is not the behaviour in Mongo, so added a fix here. Validated this in the compatibility test.

suddendust · 2026-03-08T19:45:19Z

...rg/hypertrace/core/documentstore/postgres/update/parser/PostgresAddToListIfAbsentParser.java


  @Override
  public String parseNonJsonbField(final UpdateParserInput input) {
+    if (!input.isArray()) {


Added this check to make this compatible with Mongo.

codecov · 2026-03-08T19:45:54Z

Codecov Report

❌ Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (9254122) to head (7a3b611).

Files with missing lines	Patch %	Lines
...ostgres/update/parser/PostgresUnsetPathParser.java	33.33%	2 Missing and 2 partials ⚠️
...documentstore/postgres/FlatPostgresCollection.java	96.29%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #280      +/-   ##
============================================
- Coverage     81.12%   81.12%   -0.01%     
- Complexity     1480     1485       +5     
============================================
  Files           240      240              
  Lines          7072     7124      +52     
  Branches        667      674       +7     
============================================
+ Hits           5737     5779      +42     
- Misses          911      915       +4     
- Partials        424      430       +6

Flag	Coverage Δ
integration	`81.12% <92.18%> (-0.01%)`	⬇️
unit	`55.22% <21.87%> (-0.14%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ix_setSubDocOp

…setSubDocOp # Conflicts: # document-store/src/integrationTest/java/org/hypertrace/core/documentstore/MongoPostgresWriteConsistencyTest.java # document-store/src/main/java/org/hypertrace/core/documentstore/postgres/update/parser/PostgresSetValueParser.java

suddendust · 2026-03-09T06:48:54Z

...t-store/src/main/java/org/hypertrace/core/documentstore/postgres/FlatPostgresCollection.java

+        if (isTopLevel && colMeta.isArray() && paramValue != null) {
+          Object[] arrayValues = (Object[]) paramValue;
+          Array sqlArray =
+              connection.createArrayOf(colMeta.getPostgresType().getSqlType(), arrayValues);


JDBC can't bind Object[] directly to array columns like TEXT[]. It requires java.sql.Array. So convert the Java array to JDBC Array.

puneet-traceable · 2026-03-09T17:31:10Z

@suddendust This is such a big chunk of change in tests, how are you ensuring that you are not changing tests behaviour?

suddendust · 2026-03-10T06:15:51Z

@puneet-traceable So this PR contains changes in two tests:

MongoPostgresWriteConsistencyTest: This is totally owned by me and the version that exists till now is rudimentary. This PR makes it exhaustive so it's better.
FlatCollectionWriteTest: This again is totally owned by me and I have added more exhaustive tests on the write path. You'll find that I have changed assertions at certain places. This is due to the bugs discovered via the compatibility tests (the list of bugs is in the PR description), which were fixed and which in-turn changed the behaviour. For example:

Fix the return behaviour of Collection#upsert for PG. Till now, it returns true if a new doc is created, false if it's updated. This is not inline with the contract or Mongo's behaviour - So now, it returns true if it succeeds.

So you'll find the I now do an assertTrue instead of assertFalse at certain places where I am testing upserts.

At no place any Mongo write tests have been touched.

suresh-prakash · 2026-03-12T06:18:54Z

...in/java/org/hypertrace/core/documentstore/postgres/update/parser/PostgresSetValueParser.java

+      input.getParamsBuilder().addObjectParam(values);
+    } else {
+      // For scalar columns, use standard value parser (ignore returned JSONB expression)
+      input


Bit confused here. If the result/return value is ignored, then, why call this in the first place?

suddendust added 23 commits February 25, 2026 14:48

WIP

6c19025

WIP

141636f

Fixed test cases

4e3d628

Added test cases

16abaac

Merge branch 'main' of github.com:hypertrace/document-store into pg_w…

a280617

…rite_subDocOperatorRemainingParsers

Fix failing test

d963dc7

Refactor

4f85ff4

Rollback inadvertent changes

99a0b32

WIP

651a3ea

Add MongoFlatPgConsistencyTest

63c8691

Added consistency tests for deeply nested fields

75b5943

Spotless

e7aabb6

WIP

c6953a9

WIP

86fec8b

WIP

d7540e2

WIP

0aeb9b2

WIP

086fbce

WIP

45d430a

WIP

a1b2208

Revert "WIP"

9ffdc44

This reverts commit a1b2208.

Reapply "WIP"

a81968a

This reverts commit 9ffdc44.

WIP

3bf82ae

WIP

8313386

suddendust requested review from avinashkolluru, kotharironak, puneet-traceable, skjindal93 and suresh-prakash as code owners March 8, 2026 19:43

suddendust commented Mar 8, 2026

View reviewed changes

suddendust added 4 commits March 9, 2026 11:17

Merge branch 'main' of github.com:hypertrace/document-store into bugf…

3d69e41

…ix_setSubDocOp

WIP

ee06fc7

Refactor

c509cab

suddendust changed the title ~~[Draft] [Bugfix] set sub doc op~~ Add MongoPostgresWriteConsistencyTest Mar 9, 2026

suddendust added 2 commits March 9, 2026 12:08

Spotless

950895c

Add missing file

bda4cbd

suddendust commented Mar 9, 2026

View reviewed changes

suddendust added 6 commits March 9, 2026 12:19

Add missing file

75ddcbd

WIP

84b20b9

Remove assertion on date

2a0eb52

Fix upsert behaviour for Mongo

5094189

Fix failing test cases

f9e40c5

Remove messages in assertions

d307670

Handle jsonb col names correctly for flat collections

b56210e

suresh-prakash previously approved these changes Mar 12, 2026

View reviewed changes

WIP

2be3bab

suddendust dismissed suresh-prakash’s stale review via 2be3bab March 12, 2026 07:11

suddendust changed the title ~~Add MongoPostgresWriteConsistencyTest~~ [Draft] Add MongoPostgresWriteConsistencyTest Mar 12, 2026

suddendust added 2 commits March 12, 2026 13:56

WIP

9f40ac3

Unset based on type

7a3b611

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Draft] Add MongoPostgresWriteConsistencyTest#280

[Draft] Add MongoPostgresWriteConsistencyTest#280
suddendust wants to merge 39 commits intohypertrace:mainfrom
suddendust:bugfix_setSubDocOp

suddendust commented Mar 8, 2026 •

edited

Loading

Uh oh!

suddendust Mar 8, 2026

Uh oh!

suddendust Mar 8, 2026

Uh oh!

codecov bot commented Mar 8, 2026 •

edited

Loading

Uh oh!

suddendust Mar 9, 2026

Uh oh!

puneet-traceable commented Mar 9, 2026

Uh oh!

suddendust commented Mar 10, 2026

Uh oh!

suresh-prakash Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

suddendust commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suddendust Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

suddendust Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

suddendust Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

puneet-traceable commented Mar 9, 2026

Uh oh!

suddendust commented Mar 10, 2026

Uh oh!

suresh-prakash Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

suddendust commented Mar 8, 2026 •

edited

Loading

codecov bot commented Mar 8, 2026 •

edited

Loading