Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hadolint #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add hadolint #3

wants to merge 1 commit into from

Conversation

ad-m
Copy link
Collaborator

@ad-m ad-m commented May 27, 2019

I introduced the hadolint and adapted to its requirements. Before the changes, it reported the following errors:

./php-apache/base/Dockerfile:6 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./php-apache/base/Dockerfile:7 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./php-apache/base/Dockerfile:13 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
./php-apache/base/Dockerfile:24 SC2028 echo may not expand escape sequences. Use printf.
./php-apache/7.2/Dockerfile:6 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./php-apache/7.2/Dockerfile:7 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./php-apache/7.2/Dockerfile:13 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
./php-apache/7.2/Dockerfile:24 SC2028 echo may not expand escape sequences. Use printf.
./php-apache/5.6/Dockerfile:6 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./php-apache/5.6/Dockerfile:7 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./php-apache/5.6/Dockerfile:13 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
./php-apache/5.6/Dockerfile:24 SC2028 echo may not expand escape sequences. Use printf.
./php-apache-shell/base/Dockerfile:5 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
./php-apache-shell/7.2/Dockerfile:5 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
./php-apache-shell/5.6/Dockerfile:5 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`

I do not think that we want to make all changes immediately. However, we can review rules, select which apply to facilitate future maintenance (as any tests), especially after transferring the task to fresh person.

@gregorybrzeski
Copy link
Contributor

Why hadolint ?

@ad-m
Copy link
Collaborator Author

ad-m commented May 28, 2019

This - in my opinion - is the linter with the largest community. I am open to other suggestions.

@gregorybrzeski
Copy link
Contributor

Is the largest community the most important factor to take into account in here ? any other angels ? I am not against, I just want to understand why hadolint and not something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants