Skip to content

Add docs for dgo v250 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add docs for dgo v250 #121

wants to merge 1 commit into from

Conversation

mangalaman93
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 21, 2025 11:57
@mangalaman93 mangalaman93 requested a review from a team as a code owner April 21, 2025 11:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • dgraph/sdks/go.mdx: Language not supported

Copy link
Member

@ryanfoxtyler ryanfoxtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggestions for specific details, though overall this feels verbose–for example, should we document namespaces under the client or under a doc for namespaces (with per-language examples)?

Requires at least Go 1.23
export GO111MODULE=on
go get -u -v github.com/dgraph-io/dgo/v210
# Requires at least Go 1.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the copy/paste experience → let's move the note outside of the code block

Comment on lines +32 to +35
| dgraph 23.X.Y | dgo 230.X.Y | "github.com/dgraph-io/dgo/v230" |
| dgraph 24.X.Y | dgo 240.X.Y | "github.com/dgraph-io/dgo/v240" |
| dgraph 25.X.Y | dgo 240.X.Y | "github.com/dgraph-io/dgo/v240" |
| dgraph 25.X.Y | dgo 250.X.Y | "github.com/dgraph-io/dgo/v250" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| dgraph 23.X.Y | dgo 230.X.Y | "github.com/dgraph-io/dgo/v230" |
| dgraph 24.X.Y | dgo 240.X.Y | "github.com/dgraph-io/dgo/v240" |
| dgraph 25.X.Y | dgo 240.X.Y | "github.com/dgraph-io/dgo/v240" |
| dgraph 25.X.Y | dgo 250.X.Y | "github.com/dgraph-io/dgo/v250" |
| dgraph 23.X.Y | dgo 230.X.Y | `github.com/dgraph-io/dgo/v230` |
| dgraph 24.X.Y | dgo 240.X.Y | `github.com/dgraph-io/dgo/v240` |
| dgraph 25.X.Y | dgo 240.X.Y | `github.com/dgraph-io/dgo/v240` |
| dgraph 25.X.Y | dgo 250.X.Y | `github.com/dgraph-io/dgo/v250` |

Comment on lines +39 to +40
These are _experimental_ APIs that we're still making changes to. If you have
any feedback, please let us know either on Discord or GitHub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These are _experimental_ APIs that we're still making changes to. If you have
any feedback, please let us know either on Discord or GitHub.
These APIs are released as part of the preview of Dgraph v25. They are _experimental_ APIs and subject to change before general availability. Please share feedback via [Discord](https://discord.hypermode.com) or [GitHub](https://github.com/hypermodeinc/dgo).

Comment on lines +48 to +50
`username` and `password` are optional. If username is provided, a password must
also be present. If supplied, these credentials are used to log into a Dgraph
cluster through the ACL mechanism.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true if we enable ACL by default?

| bearertoken | \<token\> | an access token |
| sslmode | disable \| require \| verify-ca | TLS option, the default is `disable`. If `verify-ca` is set, the TLS certificate configured in the Dgraph cluster must be from a valid certificate authority. |

Some example connection strings:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this detail out to the Overview page to be shared across clients?

These are _experimental_ APIs that we're still making changes to. If you have
any feedback, please let us know either on Discord or GitHub.

### Connection strings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Connection strings
### Opening a connection

// Use the client
```

### Connecting to Dgraph cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supported if Dgraph v25 is not available on Dgraph Cloud?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants