Skip to content

feat(core): Add a new string index: shingles #9463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

harshil-goel
Copy link
Contributor

No description provided.

@harshil-goel harshil-goel requested a review from a team as a code owner July 9, 2025 05:06
@github-actions github-actions bot added area/querylang Issues related to the query language specification and implementation. area/core internal mechanisms go Pull requests that update Go code labels Jul 9, 2025
Copy link

trunk-io bot commented Jul 9, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link

trunk-io bot commented Jul 9, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

tok/tok.go Outdated

for i := 0; i < n; i++ {
// unigram
shingled = append(shingled, string(tokens[i].Term))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use string builder here instead and avoid string concatenation?

fixed numgo stuff

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations

added batching for mutations
@harshil-goel harshil-goel force-pushed the harshil-goel/shingles branch from 395cf24 to 2f906ed Compare July 15, 2025 12:38
@github-actions github-actions bot added the area/testing Testing related issues label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core internal mechanisms area/querylang Issues related to the query language specification and implementation. area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

2 participants