-
Notifications
You must be signed in to change notification settings - Fork 148
Add ability to debug additional registers via gdb #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to debug additional registers via gdb #817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the debugging experience. I left some small comments here and there.
56a2912
to
3494b3e
Compare
I've updated to gdb related tests to work on Windows. This does require it to be installed on the runner vm's which is in progress. Will mark ready for review once that is complete |
3f016b8
to
6e09be9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One remark, this PR would have been a lot smaller if we had a unified Sandbox trait to address common functionality.
It would be great to get it done soon. A lot of duplicated code would get removed.
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
6e09be9
to
69aa7ee
Compare
This pull request adds support for reading and writing XMM and MXCSR registers in the GDB debug interface for all supported hypervisors (KVM, MSHV, and WHVP). It introduces new fields to the register structures to hold these values and implements the necessary logic to fetch and store them using each hypervisor's API.
Register structure updates:
xmm: [u128; 16]
andmxcsr: u32
fields to theX86_64Regs
struct to store XMM registers and MXCSR control state.Todo: