feat: add world selection for multi-world WIT files#394
feat: add world selection for multi-world WIT files#394jsturtevant wants to merge 4 commits intomainfrom
Conversation
a6cbcbf to
99bb14e
Compare
|
@jprendes the build is failing on the sysprep root. I tried downgrading to cargo-hyperlight 0.1.6 and it didn't help. I Ideas what might be going on here? I don't see much in the error message that points me in the right direction. |
|
I changed cmd.status()
- .unwrap_or_else(|e| panic!("could not run cargo build wasm_runtime: {}", e));
+ .unwrap_or_else(|e| panic!("could not run cargo build wasm_runtime: {:?}", e));and now I got a more helpful error message |
|
It looks like |
|
I will refresh this after #389 since it needs the last version of HL. I've also added a sample as a test case here. |
99bb14e to
a7cb892
Compare
|
I added an additional sample for this use case. I also moved all the samples to a structure similiar to HL guests. This had been driving me crazy for awhile so sorry for the big diff. I can do that as a followup if want but can also look at each commit. |
e9ed446 to
fd4c52e
Compare
Support WIT_WORLD_NAME env var in hyperlight-wasm-macro to select a specific world from WIT files containing multiple worlds. Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
04191b4 to
9036213
Compare
ludfjig
left a comment
There was a problem hiding this comment.
LGTM. Does runcomponent_component_type.o file need to be commited? And I seem to remember our buildscript not only rebuilt if WIT_WORLD change, but also if the file that WIT_WORLD points to change. Did we remove that?
ah good catch on that file, I guess the I am not sure on the WIT_WORLD file changes. Will need to look more closely |
ok happy to merge |
Support WIT_WORLD_NAME env var in hyperlight-wasm-macro to select a specific world from WIT files containing multiple worlds.