Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA to build, test and publish the controller image #50

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Add GHA to build, test and publish the controller image #50

merged 2 commits into from
Oct 15, 2021

Conversation

tsurai
Copy link
Contributor

@tsurai tsurai commented Oct 14, 2021

This pull request features new build and test logic for the indy node controller as well as a general rework of the github actions pipeline separating it into four distinct parts: setup, build, test, push. A small amount of repetition had to be introduced in order to get a clean logical seperation.

Fixes #49

Additionally the github actions have been split into four seperate parts

Signed-off-by: Cristian Kubis <[email protected]>
@mgmgwi
Copy link
Contributor

mgmgwi commented Oct 15, 2021

Thanks @tsurai - looking good to me.

Question: We are mixing different OS images for node and controller during the test. While this probably will work fine, I don't think someone will run this in a production environment. So we should decide whether we want to test

  • only matching OS versions (e.g. Ubunutu 18)
  • the combination
  • or if we want to create matching controller images

Any changes (if at all) should be done in another PR.

Thanks for contributing.

@mgmgwi
Copy link
Contributor

mgmgwi commented Oct 15, 2021

@Echsecutor I think you need to modify the merge checks, because some actions have different names now.

@Echsecutor Echsecutor merged commit 3eda7a8 into hyperledger:main Oct 15, 2021
@tsurai
Copy link
Contributor Author

tsurai commented Oct 15, 2021

@mgmgwi The controller image only uses a tiny subset of libindy, namely just a few constants which are being installed via pip making it OS agnostic. It shares the lo interface with its node, listening only on localhost to not expose it to anything else on the same docker network. For all intents and purposes there is no functional difference between the different OS.
At the same time the dependency on podman rules out older OS like Ubuntu 16.

@mgmgwi
Copy link
Contributor

mgmgwi commented Oct 15, 2021

Thanks for clarifying. I created #51 so we can discuss further actions in the next weekly meeting. I think larger companies have policies which OS they can use. I assume if they would run a Debian Indy Node they would most likely want to run the controller as well based on Debian.

Echsecutor added a commit that referenced this pull request Feb 4, 2022
Add GHA to build, test and publish the controller image

Signed-off-by: Sebastian Schmittner <[email protected]>
mgmgwi pushed a commit that referenced this pull request Feb 7, 2022
Add GHA to build, test and publish the controller image

Signed-off-by: Sebastian Schmittner <[email protected]>
Echsecutor added a commit that referenced this pull request Feb 11, 2022
Add GHA to build, test and publish the controller image

Signed-off-by: Sebastian Schmittner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Controller -> Include in default run setup + add Tests
3 participants