-
Notifications
You must be signed in to change notification settings - Fork 241
Update cardano connector integration #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cardano connector integration #1695
Conversation
Signed-off-by: Simon Gellis <[email protected]>
Signed-off-by: Simon Gellis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 342 342
Lines 30437 30437
=======================================
Hits 30425 30425
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Waiting for release and update to manifest.json before merging |
Signed-off-by: Simon Gellis <[email protected]>
Signed-off-by: Simon Gellis <[email protected]>
Signed-off-by: Simon Gellis <[email protected]>
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
odd tag missing
manifest.json
Outdated
| "image": "ghcr.io/hyperledger/firefly-cardanosigner", | ||
| "tag": "0.5.0", | ||
| "sha": "5af17007c13cb5325f0ae5295ff37d29f7fcd811b3d12d15d5e67cfae0d9a336" | ||
| "tag": "null", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no tag???
Signed-off-by: Simon Gellis <[email protected]>
Signed-off-by: Simon Gellis <[email protected]>
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
Proposed changes
Updates the cardano connector plugin to use versioned URLs when talking to the server.
Do not merge until we also pull in a new connector version with hyperledger/firefly-cardano#47
Also updates the documentation to remove explicit version numbers from the commands which users are meant to use. This will prevent people from accidentally installing older incompatible tooling versions if we forget to bump those version numbers again.
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.