Skip to content

Conversation

@SupernaviX
Copy link
Contributor

@SupernaviX SupernaviX commented Jul 11, 2025

Proposed changes

Updates the cardano connector plugin to use versioned URLs when talking to the server.

Do not merge until we also pull in a new connector version with hyperledger/firefly-cardano#47

Also updates the documentation to remove explicit version numbers from the commands which users are meant to use. This will prevent people from accidentally installing older incompatible tooling versions if we forget to bump those version numbers again.


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (296e796) to head (4832786).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         342      342           
  Lines       30437    30437           
=======================================
  Hits        30425    30425           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

EnriqueL8
EnriqueL8 previously approved these changes Jul 14, 2025
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@EnriqueL8
Copy link
Contributor

Waiting for release and update to manifest.json before merging

Signed-off-by: Simon Gellis <[email protected]>
@SupernaviX SupernaviX marked this pull request as ready for review July 14, 2025 14:42
@SupernaviX SupernaviX requested a review from a team as a code owner July 14, 2025 14:42
Signed-off-by: Simon Gellis <[email protected]>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd tag missing

manifest.json Outdated
"image": "ghcr.io/hyperledger/firefly-cardanosigner",
"tag": "0.5.0",
"sha": "5af17007c13cb5325f0ae5295ff37d29f7fcd811b3d12d15d5e67cfae0d9a336"
"tag": "null",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tag???

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@EnriqueL8 EnriqueL8 merged commit 8863076 into hyperledger:main Jul 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants