Exploit new support in firefly-signer and firefly-common for large & scientific JSON numbers
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
matthew1001
force-pushed
the
large-json-numbers
branch
from
9ca83c2
to
20dfcbb
Compare
Signed-off-by: Matthew Whitehead <[email protected]>
EnriqueL8
approved these changes
Sep 3, 2024
| @@ -95,7 +95,7 @@ func (c *ethConnector) prepareDeployData(ctx context.Context, req *ffcapi.Contra | |||
| ethParams := make([]interface{}, len(req.Params)) | |||
| for i, p := range req.Params { | |||
| if p != nil { | |||
| err := json.Unmarshal([]byte(*p), ðParams[i]) | |||
| err := p.Unmarshal(ctx, ðParams[i]) | |||
There was a problem hiding this comment.
For context: The type of p is *fftypes.JSONAny which has implemented an Unmarshal method
| @@ -39,19 +40,91 @@ const samplePrepareDeployTX = `{ | |||
| "gas": 1000000, | |||
| "nonce": "111", | |||
| "value": "12345678901234567890123456789", | |||
| "contract": "0xfeedbeef", | |||
| "contract": "0xdeadbeef", | |||
There was a problem hiding this comment.
Yeah a slightly cheeky way to ensure the asserts in the tests don't match on the contract bytes when checking for integers that match 0xdeadbeef
EnriqueL8
requested changes
Sep 3, 2024
|
You need the same fix in |
|
Could it also affect the gas price ? |
Signed-off-by: Matthew Whitehead <[email protected]>
Good spot, will address that now |
I think this case is OK as we're specifically unmarshaling to a |
Signed-off-by: Matthew Whitehead <[email protected]>
|
@EnriqueL8 new commits added to handle the |
|
Not sure why codecov is not enabled here... |
|
Okay I've enabled CodeCov on this repo |
|
Re-Running Jobs to upload coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
firefly-common(see especially PR Add support for 256 bit JSON numbers (vs. strings) firefly-common#147)firefly-signer(see especially PR Add support for 256 bit JSON numbers (vs. strings), including scientific notation firefly-signer#76)firefly-transaction-manager(see especially PR Update to the latest release of firefly-common firefly-transaction-manager#128)