Add support for large numbers, and exploit new support in firefly-signer for scientific notation numbers
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
|
This PR pre-reqs hyperledger/firefly-signer#76 so is currently in draft while that PR is discussed. |
matthew1001
changed the title
firefly-signer for large numbers and scientific notation numbers
matthew1001
changed the title
firefly-signer for large numbers and scientific notation numbersfirefly-signer for scientific notation numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firefly-signerPR #150 adds support for parsing scientific notation numbers usingbig.ParseFloat(). This PR pulls in the new version offirefly-signer, and changes the type that input params are unmarshalled to, frominterface{}tofftpyes.JSONAny. The latter ensures that large numbers (e.g.10000000000000000000aren't converted tofloat64and hence lose data.