Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for large numbers, and exploit new support in firefly-signer for scientific notation numbers #150

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

matthew1001
Copy link
Contributor

@matthew1001 matthew1001 commented Aug 23, 2024

firefly-signer PR #150 adds support for parsing scientific notation numbers using big.ParseFloat(). This PR pulls in the new version of firefly-signer, and changes the type that input params are unmarshalled to, from interface{} to fftpyes.JSONAny. The latter ensures that large numbers (e.g. 10000000000000000000 aren't converted to float64 and hence lose data.

@matthew1001
Copy link
Contributor Author

This PR pre-reqs hyperledger/firefly-signer#76 so is currently in draft while that PR is discussed.

@matthew1001 matthew1001 changed the title Large numbers Exploit new support in firefly-signer for large numbers and scientific notation numbers Aug 23, 2024
@matthew1001 matthew1001 changed the title Exploit new support in firefly-signer for large numbers and scientific notation numbers Add support for large numbers, and exploit new support in firefly-signer for scientific notation numbers Aug 23, 2024
@matthew1001 matthew1001 merged commit 126b710 into main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant