Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the revert reason is present in a receipt, skip the call to debug_traceTransaction #128

Merged
merged 8 commits into from
Apr 8, 2024
Merged

If the revert reason is present in a receipt, skip the call to debug_traceTransaction #128

merged 8 commits into from
Apr 8, 2024

Conversation

matthew1001
Copy link
Contributor

@matthew1001 matthew1001 commented Apr 8, 2024 •
edited
Loading

Also re-instate odd-length hex padding with leading 0 (see #112)

@matthew1001
Check for the revert reason in the TX receipt before using debug_trac…
40f69c1 
…eTransaction

Signed-off-by: Matthew Whitehead <[email protected]>
@matthew1001
Restore padding of leading 0 for odd-length hex strings
c136537 
Signed-off-by: Matthew Whitehead <[email protected]>
@matthew1001
Typo
15cfefb 
Signed-off-by: Matthew Whitehead <[email protected]>
@matthew1001
Add more logs
7a846c5 
Signed-off-by: Matthew Whitehead <[email protected]>
@matthew1001
Add more logs
7afad6b 
Signed-off-by: Matthew Whitehead <[email protected]>
@matthew1001
Remove debug logs, add unit test to retain 100% coverage
1facd19 
Signed-off-by: Matthew Whitehead <[email protected]>
@matthew1001 matthew1001 marked this pull request as ready for review April 8, 2024 12:39
@matthew1001 matthew1001 requested a review from a team as a code owner April 8, 2024 12:39
Chengxuan
Chengxuan requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Chengxuan Chengxuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor comments to avoid the amount of debug level logs being overwhelming

internal/ethereum/get_receipt.go Outdated Show resolved Hide resolved
internal/ethereum/get_receipt.go Outdated Show resolved Hide resolved
matthew1001 and others added 2 commits April 8, 2024 16:34
@matthew1001 @Chengxuan
Update internal/ethereum/get_receipt.go
bb1f5ad 
Co-authored-by: Chengxuan Xing <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>
@matthew1001 @Chengxuan
Update internal/ethereum/get_receipt.go
50b17d6 
Co-authored-by: Chengxuan Xing <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>
Chengxuan
Chengxuan approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Chengxuan Chengxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chengxuan Chengxuan merged commit 29020f8 into hyperledger:main Apr 8, 2024
3 checks passed
@Chengxuan Chengxuan deleted the receipt-revert-reason branch April 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chengxuan Chengxuan Chengxuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew1001 @Chengxuan