Skip to content

Commit

Permalink
Use require to import long (#683)
Browse files Browse the repository at this point in the history
Explicit require provides better TypeScript compatibility regardless of esModuleInterop setting.

Signed-off-by: Mark S. Lewis <[email protected]>
  • Loading branch information
bestbeforetoday committed Sep 11, 2023
1 parent 8743c2e commit 8372964
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion fabric-common/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
/* eslint-disable @typescript-eslint/explicit-module-boundary-types */

import Long from 'long';
import Long = require('long');
import * as fabproto6 from 'fabric-protos';
import winston = require('winston');

Expand Down
2 changes: 1 addition & 1 deletion fabric-network/src/checkpointer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* SPDX-License-Identifier: Apache-2.0
*/

import Long from 'long';
import Long = require('long');

export interface Checkpointer {
addTransactionId(transactionId: string): Promise<void>;
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/src/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import {BlockType, Endorser} from 'fabric-common';
import * as fabproto6 from 'fabric-protos';
import {Checkpointer} from './checkpointer';
import Long from 'long';
import Long = require('long');

export type EventType = BlockType;

Expand Down
2 changes: 1 addition & 1 deletion fabric-network/src/impl/event/blockeventsource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {newFullBlockEvent} from './fullblockeventfactory';
import {OrderedBlockQueue} from './orderedblockqueue';
import {newPrivateBlockEvent} from './privateblockeventfactory';
import {notNullish} from '../gatewayutils';
import Long from 'long';
import Long = require('long');

const logger = Logger.getLogger('BlockEventSource');

Expand Down
2 changes: 1 addition & 1 deletion fabric-network/src/impl/event/orderedblockqueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import {BlockEvent} from '../../events';
import Long from 'long';
import Long = require('long');

export class OrderedBlockQueue {
private readonly queue = new Map<string, BlockEvent>();
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/src/impl/filecheckpointer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import {Checkpointer} from '../checkpointer';
import Long from 'long';
import Long = require('long');
import * as fs from 'fs';

const encoding = 'utf8';
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/test/impl/event/commitlistener.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
Client,
Eventer
} from 'fabric-common';
import Long from 'long';
import Long = require('long');

import {NetworkImpl} from '../../../src/network';
import {EventServiceManager} from '../../../src/impl/event/eventservicemanager';
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/test/impl/event/contractlistener.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

import * as sinon from 'sinon';
import {expect} from 'chai';
import Long from 'long';
import Long = require('long');

import {Channel, Client, Endorser, Eventer, EventInfo, IdentityContext} from 'fabric-common';
import * as fabproto6 from 'fabric-protos';
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/test/impl/event/listeners.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import * as Listeners from '../../../src/impl/event/listeners';
import {StubCheckpointer} from './stubcheckpointer';
import {BlockEvent, BlockListener, TransactionEvent, ContractEvent} from '../../../src/events';
import Long from 'long';
import Long = require('long');
import * as chai from 'chai';
import * as sinon from 'sinon';

Expand Down
2 changes: 1 addition & 1 deletion fabric-network/test/impl/event/orderedblockqueue.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import {BlockEvent} from '../../../src/events';
import {OrderedBlockQueue} from '../../../src/impl/event/orderedblockqueue';
import Long from 'long';
import Long = require('long');

import * as chai from 'chai';
const expect = chai.expect;
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/test/impl/event/stubcheckpointer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import {Checkpointer} from '../../../src/checkpointer';
import Long from 'long';
import Long = require('long');

export class StubCheckpointer implements Checkpointer {
private blockNumber: Long;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
EventInfo,
IdentityContext
} from 'fabric-common';
import Long from 'long';
import Long = require('long');

import {Gateway, ConnectedGatewayOptions} from '../../../src/gateway';
import {Network, NetworkImpl} from '../../../src/network';
Expand Down
2 changes: 1 addition & 1 deletion fabric-network/test/impl/filecheckpointer.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import {Checkpointer} from '../../src/checkpointer';
import {DefaultCheckpointers} from '../../src/defaultcheckpointers';
import * as testUtils from '../testutils';
import Long from 'long';
import Long = require('long');
import * as path from 'path';
import * as fs from 'fs';
import * as chai from 'chai';
Expand Down
2 changes: 1 addition & 1 deletion test/ts-scenario/src/steps/lib/listeners.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import * as Constants from '../constants';
import * as GatewayHelper from './gateway';
import * as BaseUtils from './utility/baseUtils';
import {StateStore} from './utility/stateStore';
import Long from 'long';
import Long = require('long');
import * as fs from 'fs';
import * as path from 'path';
import * as os from 'os';
Expand Down
2 changes: 1 addition & 1 deletion test/ts-scenario/src/steps/lib/utility/clientUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
StartRequestOptions, SendEventOptions, BuildProposalRequest, SendProposalRequest, EventRegistrationOptions, EventListener
} from 'fabric-common';
import * as fs from 'fs';
import Long from 'long';
import Long = require('long');
import * as Constants from '../../constants';
import * as BaseUtils from './baseUtils';
import {CommonConnectionProfileHelper} from './commonConnectionProfileHelper';
Expand Down

0 comments on commit 8372964

Please sign in to comment.