Do not create unchanged accounts in BlockAccessListStateRootHashCalculator #9361
+58
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lator Signed-off-by: Miroslav Kovar <[email protected]>
Signed-off-by: Miroslav Kovar <[email protected]>
mirgee
force-pushed
the
fix-bal-state-root-calculator
branch
from
ace6f65 to
98bfd10
Compare
matkt
reviewed
Oct 24, 2025
...er/besu/ethereum/trie/pathbased/bonsai/worldview/BlockAccessListStateRootHashCalculator.java
Show resolved
Hide resolved
mirgee
commented
Oct 24, 2025
| } | ||
| } | ||
|
|
||
| accumulator.clearAccountsThatAreEmpty(); |
There was a problem hiding this comment.
This is probably not necessary but I think it's safer to keep it.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
BlockAccessListStateRootHashCalculator#accumulateAccessListAndComputeRootcreates accounts in the accumulator which have been only read. If an account doesn't exist at the beginning at the block processing and is only read (i.e. remains unchanged), it is not part of the state and should not be considered for the state root computation per EIP-161.