Assign background transaction futures to the tracking array so they can be cancelled #9360
      
        
          +14
        
        
          −12
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This could improve performance in the cases where sequential execution beats parallel, particularly when dealing with a large transaction such as a XEN contract: if sequential processing catches up, cancel the parallel tx future and process the tx once sequentially instead of leaving the parallel tx future to complete in the background.
Testing
Test was run over 2.5 days, ~18K blocks.
Full analysis report: https://hackmd.io/@siladu/HypqnrhCxl
Analysis shows no regression and perhaps some limited improvements to specific blocks, though comparing to all our running nodes' block times, I think this is likely noise.
One outlier result for block 23647133 skews the report quite a lot.
Files used in analysis
Besu Logs
Analysis tool (usage in the hackmd report)
XEN contract transaction lists